Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-29 06:12:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

net: rds: drop VLA in rds_for_each_conn_info()

Browse Source 
Avoid VLA[1] by using an already allocated buffer passed
by the caller.

[1] https://lkml.org/lkml/2018/3/7/621

Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Salvatore Mesoraca 2018-03-11 22:07:49 +01:00 committed by David S. Miller
parent 3ed898e8cd
commit f1cb9d68b4
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/rds/connection.c
View File

@ -540,9 +540,9 @@ void rds_for_each_conn_info(struct socket *sock, unsigned int len,
struct rds_info_iterator *iter, struct rds_info_iterator *iter,
struct rds_info_lengths *lens, struct rds_info_lengths *lens,
int (*visitor)(struct rds_connection *, void *), int (*visitor)(struct rds_connection *, void *),
u64 *buffer,
size_t item_len) size_t item_len)
{ {
uint64_t buffer[(item_len + 7) / 8];
struct hlist_head *head; struct hlist_head *head;
struct rds_connection *conn; struct rds_connection *conn;
size_t i; size_t i;

3
net/rds/ib.c
View File

@ -321,8 +321,11 @@ static void rds_ib_ic_info(struct socket *sock, unsigned int len,
struct rds_info_iterator *iter, struct rds_info_iterator *iter,
struct rds_info_lengths *lens) struct rds_info_lengths *lens)
{ {
u64 buffer[(sizeof(struct rds_info_rdma_connection) + 7) / 8];
rds_for_each_conn_info(sock, len, iter, lens, rds_for_each_conn_info(sock, len, iter, lens,
rds_ib_conn_info_visitor, rds_ib_conn_info_visitor,
buffer,
sizeof(struct rds_info_rdma_connection)); sizeof(struct rds_info_rdma_connection));
} }

1
net/rds/rds.h
View File

@ -735,6 +735,7 @@ void rds_for_each_conn_info(struct socket *sock, unsigned int len,
struct rds_info_iterator *iter, struct rds_info_iterator *iter,
struct rds_info_lengths *lens, struct rds_info_lengths *lens,
int (*visitor)(struct rds_connection *, void *), int (*visitor)(struct rds_connection *, void *),
u64 *buffer,
size_t item_len); size_t item_len);
__printf(2, 3) __printf(2, 3)