Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 14:11:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

component: do not dereference opaque pointer in debugfs

Browse Source 
The match data does not have to be a struct device pointer, and indeed
very often is not. Attempt to treat it as such easily results in a
crash.

For the components that are not registered, we don't know which device
is missing. Once it it is there, we can use the struct component to get
the device and whether it's bound or not.

Fixes: 59e73854b5 ('component: add debugfs support')
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Cc: stable <stable@vger.kernel.org>
Cc: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Link: https://lore.kernel.org/r/20191118115431.63626-1-lkundrak@v3.sk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Lubomir Rintel 2019-11-18 12:54:31 +01:00 committed by Greg Kroah-Hartman
parent e2f3733207
commit ef9ffc1e5f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/base/component.c
View File

@ -101,11 +101,11 @@ static int component_devices_show(struct seq_file *s, void *data)
seq_printf(s, "%-40s %20s\n", "device name", "status"); seq_printf(s, "%-40s %20s\n", "device name", "status");
seq_puts(s, "-------------------------------------------------------------\n"); seq_puts(s, "-------------------------------------------------------------\n");
for (i = 0; i < match->num; i++) { for (i = 0; i < match->num; i++) {
struct device *d = (struct device *)match->compare[i].data; struct component *component = match->compare[i].component;
seq_printf(s, "%-40s %20s\n", dev_name(d), seq_printf(s, "%-40s %20s\n",
match->compare[i].component ? component ? dev_name(component->dev) : "(unknown)",
"registered" : "not registered"); component ? (component->bound ? "bound" : "not bound") : "not registered");
} }
mutex_unlock(&component_mutex); mutex_unlock(&component_mutex);