Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-12 23:23:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

HID: rmi: remove #ifdef CONFIG_PM

Browse Source 
Through the usage of pm_ptr() the CONFIG_PM-dependent code will always be
compiled, protecting against bitrot.
The linker will then garbage-collect the unused function avoiding any overhead.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20231012-hid-pm_ptr-v1-4-0a71531ca93b@weissschuh.net
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
This commit is contained in:
Thomas Weißschuh 2023-10-12 12:23:41 +02:00 committed by Benjamin Tissoires
parent fc2543414c
commit eeebfe6259
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/hid/hid-rmi.c
View File

@ -436,7 +436,6 @@ static void rmi_report(struct hid_device *hid, struct hid_report *report)
input_sync(field->hidinput->input); input_sync(field->hidinput->input);
} }
#ifdef CONFIG_PM
static int rmi_suspend(struct hid_device *hdev, pm_message_t message) static int rmi_suspend(struct hid_device *hdev, pm_message_t message)
{ {
struct rmi_data *data = hid_get_drvdata(hdev); struct rmi_data *data = hid_get_drvdata(hdev);
@ -483,7 +482,6 @@ out:
hid_hw_close(hdev); hid_hw_close(hdev);
return ret; return ret;
} }
#endif /* CONFIG_PM */
static int rmi_hid_reset(struct rmi_transport_dev *xport, u16 reset_addr) static int rmi_hid_reset(struct rmi_transport_dev *xport, u16 reset_addr)
{ {
@ -774,11 +772,9 @@ static struct hid_driver rmi_driver = {
.report = rmi_report, .report = rmi_report,
.input_mapping = rmi_input_mapping, .input_mapping = rmi_input_mapping,
.input_configured = rmi_input_configured, .input_configured = rmi_input_configured,
#ifdef CONFIG_PM .suspend = pm_ptr(rmi_suspend),
.suspend = rmi_suspend, .resume = pm_ptr(rmi_post_resume),
.resume = rmi_post_resume, .reset_resume = pm_ptr(rmi_post_resume),
.reset_resume = rmi_post_resume,
#endif
}; };
module_hid_driver(rmi_driver); module_hid_driver(rmi_driver);