Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 22:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

ALSA: hda: cs35l41: Do not allow uninitialised variables to be freed

Browse Source 
Initialise the variables to NULL so that they cannot be uninitialised
when devm_kfree is called.

Found by static analysis.

Fixes: 8c4c216db8 ("ALSA: hda: cs35l41: Add config table to support many laptops without _DSD")

Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20231219162232.790358-2-sbinding@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Stefan Binding 2023-12-19 16:22:31 +00:00 committed by Takashi Iwai
parent 092a136247
commit ed7326a24a
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sound/pci/hda/cs35l41_hda_property.c
View File

@ -77,10 +77,10 @@ static const struct cs35l41_config cs35l41_config_table[] = {
static int cs35l41_add_gpios(struct cs35l41_hda *cs35l41, struct device *physdev, int reset_gpio, static int cs35l41_add_gpios(struct cs35l41_hda *cs35l41, struct device *physdev, int reset_gpio,
int spkid_gpio, int cs_gpio_index, int num_amps) int spkid_gpio, int cs_gpio_index, int num_amps)
{ {
struct acpi_gpio_mapping *gpio_mapping; struct acpi_gpio_mapping *gpio_mapping = NULL;
struct acpi_gpio_params *reset_gpio_params; struct acpi_gpio_params *reset_gpio_params = NULL;
struct acpi_gpio_params *spkid_gpio_params; struct acpi_gpio_params *spkid_gpio_params = NULL;
struct acpi_gpio_params *cs_gpio_params; struct acpi_gpio_params *cs_gpio_params = NULL;
unsigned int num_entries = 0; unsigned int num_entries = 0;
unsigned int reset_index, spkid_index, csgpio_index; unsigned int reset_index, spkid_index, csgpio_index;
int i; int i;