Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-16 09:02:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

f2fs: remove redundant set_page_dirty from write_compacted_summaries

Browse Source 
Previously, set_page_dirty is called every time after writting one summary info
into compacted summary page,
To avoid redundant set_page_dirty, we only call set_page_dirty before release
page.

Signed-off-by: Yu Chao <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
This commit is contained in:
Chao Yu 2013-10-24 15:08:28 +08:00 committed by Jaegeuk Kim
parent ea91e9b043
commit e8d61a7488
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/f2fs/segment.c
View File

@ -1138,8 +1138,6 @@ static void write_compacted_summaries(struct f2fs_sb_info *sbi, block_t blkaddr)
SUM_JOURNAL_SIZE); SUM_JOURNAL_SIZE);
written_size += SUM_JOURNAL_SIZE; written_size += SUM_JOURNAL_SIZE;
set_page_dirty(page);
/* Step 3: write summary entries */ /* Step 3: write summary entries */
for (i = CURSEG_HOT_DATA; i <= CURSEG_COLD_DATA; i++) { for (i = CURSEG_HOT_DATA; i <= CURSEG_COLD_DATA; i++) {
unsigned short blkoff; unsigned short blkoff;
@ -1158,18 +1156,20 @@ static void write_compacted_summaries(struct f2fs_sb_info *sbi, block_t blkaddr)
summary = (struct f2fs_summary *)(kaddr + written_size); summary = (struct f2fs_summary *)(kaddr + written_size);
*summary = seg_i->sum_blk->entries[j]; *summary = seg_i->sum_blk->entries[j];
written_size += SUMMARY_SIZE; written_size += SUMMARY_SIZE;
set_page_dirty(page);
if (written_size + SUMMARY_SIZE <= PAGE_CACHE_SIZE - if (written_size + SUMMARY_SIZE <= PAGE_CACHE_SIZE -
SUM_FOOTER_SIZE) SUM_FOOTER_SIZE)
continue; continue;
set_page_dirty(page);
f2fs_put_page(page, 1); f2fs_put_page(page, 1);
page = NULL; page = NULL;
} }
} }
if (page) if (page) {
set_page_dirty(page);
f2fs_put_page(page, 1); f2fs_put_page(page, 1);
}
} }
static void write_normal_summaries(struct f2fs_sb_info *sbi, static void write_normal_summaries(struct f2fs_sb_info *sbi,