Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 14:42:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: samsung idma: Add proper annotation for casting iomem pointers

Browse Source 
It is not always possible to interchange iomem pointers with normal pointers,
which why we have annotations for iomem pointers and warn when casting them to a
normal pointer or vice versa. In this case the casting is fine and unfortunately
necessary so add the proper annotations to tell code checkers that it is
intentional. This silences the following warnings from sparse:
	sound/soc/samsung/idma.c:354:20: warning: incorrect type in argument 1
	 (different address spaces) expected void volatile [noderef]
	  <asn:2>*addr got unsigned char *area
	sound/soc/samsung/idma.c:372:22: warning: cast removes address space of
	 expression

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
Lars-Peter Clausen 2014-08-17 16:18:21 +02:00 committed by Mark Brown
parent d80a12f924
commit e8a70c25b8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sound/soc/samsung/idma.c
View File

@ -351,7 +351,7 @@ static void idma_free(struct snd_pcm *pcm)
if (!buf->area) if (!buf->area)
return; return;
iounmap(buf->area); iounmap((void __iomem *)buf->area);
buf->area = NULL; buf->area = NULL;
buf->addr = 0; buf->addr = 0;
@ -369,7 +369,7 @@ static int preallocate_idma_buffer(struct snd_pcm *pcm, int stream)
buf->dev.type = SNDRV_DMA_TYPE_CONTINUOUS; buf->dev.type = SNDRV_DMA_TYPE_CONTINUOUS;
buf->addr = idma.lp_tx_addr; buf->addr = idma.lp_tx_addr;
buf->bytes = idma_hardware.buffer_bytes_max; buf->bytes = idma_hardware.buffer_bytes_max;
buf->area = (unsigned char *)ioremap(buf->addr, buf->bytes); buf->area = (unsigned char * __force)ioremap(buf->addr, buf->bytes);
return 0; return 0;
} }