Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 06:31:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

drivers/iio/industrialio-event.c: eliminate possible double free

Browse Source 
The function __iio_add_event_config_attrs is only called once, by the
function iio_device_register_eventset.  If the call fails,
iio_device_register_eventset calls __iio_remove_event_config_attrs.  There
is thus no need for __iio_add_event_config_attrs to also call
__iio_remove_event_config_attrs on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f,free,a;
parameter list[n] ps;
type T;
expression e;
@@

f(ps,T a,...) {
  ... when any
      when != a = e
  if(...) { ... free(a); ... return ...; }
  ... when any
}

@@
identifier r.f,r.free;
expression x,a;
expression list[r.n] xs;
@@

* x = f(xs,a,...);
  if (...) { ... free(a); ... return ...; }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:
Julia Lawall 2012-10-21 11:52:00 +01:00 committed by Jonathan Cameron
parent e8f45e3341
commit e3db9ef6eb
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/iio/industrialio-event.c
View File

@ -350,15 +350,10 @@ static inline int __iio_add_event_config_attrs(struct iio_dev *indio_dev)
ret = iio_device_add_event_sysfs(indio_dev, ret = iio_device_add_event_sysfs(indio_dev,
&indio_dev->channels[j]); &indio_dev->channels[j]);
if (ret < 0) if (ret < 0)
goto error_clear_attrs; return ret;
attrcount += ret; attrcount += ret;
} }
return attrcount; return attrcount;
error_clear_attrs:
__iio_remove_event_config_attrs(indio_dev);
return ret;
} }
static bool iio_check_for_dynamic_events(struct iio_dev *indio_dev) static bool iio_check_for_dynamic_events(struct iio_dev *indio_dev)