mirror of
https://github.com/torvalds/linux.git
synced 2024-11-19 18:41:48 +00:00
ASoC: Intel: fix runtime pm imbalance on error
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Junjie Mao <junjie.mao@enight.me> Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
c9b1e834bc
commit
e1d46d30d1
@ -152,6 +152,7 @@ static int sst_power_control(struct device *dev, bool state)
|
||||
|
||||
dev_dbg(ctx->dev, "Enable: pm usage count: %d\n", usage_count);
|
||||
if (ret < 0) {
|
||||
pm_runtime_put_sync(dev);
|
||||
dev_err(ctx->dev, "Runtime get failed with err: %d\n", ret);
|
||||
return ret;
|
||||
}
|
||||
@ -204,8 +205,10 @@ static int sst_cdev_open(struct device *dev,
|
||||
struct intel_sst_drv *ctx = dev_get_drvdata(dev);
|
||||
|
||||
retval = pm_runtime_get_sync(ctx->dev);
|
||||
if (retval < 0)
|
||||
if (retval < 0) {
|
||||
pm_runtime_put_sync(ctx->dev);
|
||||
return retval;
|
||||
}
|
||||
|
||||
str_id = sst_get_stream(ctx, str_params);
|
||||
if (str_id > 0) {
|
||||
@ -672,8 +675,10 @@ static int sst_send_byte_stream(struct device *dev,
|
||||
if (NULL == bytes)
|
||||
return -EINVAL;
|
||||
ret_val = pm_runtime_get_sync(ctx->dev);
|
||||
if (ret_val < 0)
|
||||
if (ret_val < 0) {
|
||||
pm_runtime_put_sync(ctx->dev);
|
||||
return ret_val;
|
||||
}
|
||||
|
||||
ret_val = sst_send_byte_stream_mrfld(ctx, bytes);
|
||||
sst_pm_runtime_put(ctx);
|
||||
|
Loading…
Reference in New Issue
Block a user