mirror of
https://github.com/torvalds/linux.git
synced 2024-11-11 14:42:24 +00:00
netfilter: nf_log: fix uninit read in nf_log_proc_dostring
When proc_dostring() is called with a non-zero offset in strict mode, it
doesn't just write to the ->data buffer, it also reads. Make sure it
doesn't read uninitialized data.
Fixes: c6ac37d8d8
("netfilter: nf_log: fix error on write NONE to [...]")
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
This commit is contained in:
parent
ad9852af97
commit
dffd22aed2
@ -424,6 +424,10 @@ static int nf_log_proc_dostring(struct ctl_table *table, int write,
|
||||
if (write) {
|
||||
struct ctl_table tmp = *table;
|
||||
|
||||
/* proc_dostring() can append to existing strings, so we need to
|
||||
* initialize it as an empty string.
|
||||
*/
|
||||
buf[0] = '\0';
|
||||
tmp.data = buf;
|
||||
r = proc_dostring(&tmp, write, buffer, lenp, ppos);
|
||||
if (r)
|
||||
|
Loading…
Reference in New Issue
Block a user