Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-19 18:41:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

drbd: Remove unnecessary reference counting left-over

Browse Source 
Nothing in this function accesses mdev->tconn->net_conf, so there is no
need for get_net_conf() / put_net_conf() anymore.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
This commit is contained in:
Andreas Gruenbacher 2011-01-28 14:24:05 +01:00 committed by Philipp Reisner
parent 5e4722645a
commit ddd8877d31
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/block/drbd/drbd_req.c
View File

@ -328,9 +328,6 @@ static int _req_conflicts(struct drbd_request *req)
D_ASSERT(drbd_interval_empty(&req->i));
if (!get_net_conf(mdev->tconn))
return 0;
i = drbd_find_overlap(&mdev->write_requests, sector, size);
if (i) {
dev_alert(DEV, "%s[%u] Concurrent %s write detected! "
@ -340,18 +337,10 @@ static int _req_conflicts(struct drbd_request *req)
i->local ? "local" : "remote",
(unsigned long long)sector, size,
(unsigned long long)i->sector, i->size);
goto out_conflict;
}
/* this is like it should be, and what we expected.
* our users do behave after all... */
put_net_conf(mdev->tconn);
return 0;
out_conflict:
put_net_conf(mdev->tconn);
return 1;
}
return 0;
}
/* obviously this could be coded as many single functions
* instead of one huge switch,