Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 14:11:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

headers_check: fix perl warnings

Browse Source 
According to PBP; best way practice is to use local reference for file
handle and three argument open. Also perl prototypes are a mistake.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: WANG Cong <amwang@redhat.com>
Cc: Michal Marek <mmarek@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>
This commit is contained in:
Stephen Hemminger 2010-02-22 15:17:24 -08:00 committed by Michal Marek
parent 91416cfdf9
commit dbbe33e99f
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
scripts/headers_check.pl
View File

@ -28,11 +28,12 @@ my $lineno = 0;
my $filename; my $filename;
foreach my $file (@files) { foreach my $file (@files) {
local *FH;
$filename = $file; $filename = $file;
open(FH, "<$filename") or die "$filename: $!\n";
open(my $fh, '<', $filename)
or die "$filename: $!\n";
$lineno = 0; $lineno = 0;
while ($line = <FH>) { while ($line = <$fh>) {
$lineno++; $lineno++;
&check_include(); &check_include();
&check_asm_types(); &check_asm_types();
@ -40,7 +41,7 @@ foreach my $file (@files) {
&check_declarations(); &check_declarations();
# Dropped for now. Too much noise &check_config(); # Dropped for now. Too much noise &check_config();
} }
close FH; close $fh;
} }
exit $ret; exit $ret;
@ -78,7 +79,7 @@ sub check_config
} }
my $linux_asm_types; my $linux_asm_types;
sub check_asm_types() sub check_asm_types
{ {
if ($filename =~ /types.h|int-l64.h|int-ll64.h/o) { if ($filename =~ /types.h|int-l64.h|int-ll64.h/o) {
return; return;