Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-16 00:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

block/null_blk: Fix completion processing from LIFO to FIFO

Browse Source 
The completion queue is implemented using lockless list.

The llist_add is adds the events to the list head which is a push operation.
The processing of the completion elements is done by disconnecting all the
pushed elements and iterating over the disconnected list. The problem is
that the processing is done in reverse order w.r.t order of the insertion
i.e. LIFO processing. By reversing the disconnected list which is done in
linear time the desired FIFO processing is achieved.

Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
This commit is contained in:
Shlomo Pongratz 2014-02-06 18:33:17 +02:00 committed by Jens Axboe
parent 5cb8850c9c
commit d7790b928d
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/block/null_blk.c
View File

@ -195,6 +195,7 @@ static enum hrtimer_restart null_cmd_timer_expired(struct hrtimer *timer)
cq = &per_cpu(completion_queues, smp_processor_id()); cq = &per_cpu(completion_queues, smp_processor_id());
while ((entry = llist_del_all(&cq->list)) != NULL) { while ((entry = llist_del_all(&cq->list)) != NULL) {
entry = llist_reverse_order(entry);
do { do {
cmd = container_of(entry, struct nullb_cmd, ll_list); cmd = container_of(entry, struct nullb_cmd, ll_list);
end_cmd(cmd); end_cmd(cmd);
@ -235,6 +236,7 @@ static void null_ipi_cmd_end_io(void *data)
cq = &per_cpu(completion_queues, smp_processor_id()); cq = &per_cpu(completion_queues, smp_processor_id());
entry = llist_del_all(&cq->list); entry = llist_del_all(&cq->list);
entry = llist_reverse_order(entry);
while (entry) { while (entry) {
next = entry->next; next = entry->next;