Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-17 09:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[NET]: Fix logical error in skb_gso_ok

Browse Source 
The test in skb_gso_ok is backwards.  Noticed by Michael Chan
<mchan@broadcom.com>.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Herbert Xu 2006-06-29 12:25:53 -07:00 committed by David S. Miller
parent 4ee303dfea
commit d6b4991ad5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/linux/netdevice.h
View File

@ -994,12 +994,12 @@ static inline int skb_gso_ok(struct sk_buff *skb, int features)
{ {
int feature = skb_shinfo(skb)->gso_size ? int feature = skb_shinfo(skb)->gso_size ?
skb_shinfo(skb)->gso_type << NETIF_F_GSO_SHIFT : 0; skb_shinfo(skb)->gso_type << NETIF_F_GSO_SHIFT : 0;
return (features & feature) != feature; return (features & feature) == feature;
} }
static inline int netif_needs_gso(struct net_device *dev, struct sk_buff *skb) static inline int netif_needs_gso(struct net_device *dev, struct sk_buff *skb)
{ {
return skb_gso_ok(skb, dev->features); return !skb_gso_ok(skb, dev->features);
} }
#endif /* __KERNEL__ */ #endif /* __KERNEL__ */