Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-29 14:21:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: Intel: avs-max98357a: remove redundant dapm routes

Browse Source 
The route "HiFi Playback<-sspX Tx" is created by
snd_soc_dapm_connect_dai_link_widgets() automatically. Remove the
duplicate routes.

Signed-off-by: Brent Lu <brent.lu@intel.com>
Link: https://lore.kernel.org/r/20230612110958.592674-5-brent.lu@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Brent Lu 2023-06-12 19:09:50 +08:00 committed by Mark Brown
parent 12ea56d73c
commit d48e3cd5aa
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 3 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
sound/soc/intel/avs/boards/max98357a.c
View File

@ -86,41 +86,14 @@ static int avs_create_dai_link(struct device *dev, const char *platform_name, in
return 0; return 0;
} }
static int avs_create_dapm_routes(struct device *dev, int ssp_port,
struct snd_soc_dapm_route **routes, int *num_routes)
{
struct snd_soc_dapm_route *dr;
const int num_base = ARRAY_SIZE(card_base_routes);
const int num_dr = num_base + 1;
int idx;
dr = devm_kcalloc(dev, num_dr, sizeof(*dr), GFP_KERNEL);
if (!dr)
return -ENOMEM;
memcpy(dr, card_base_routes, num_base * sizeof(*dr));
idx = num_base;
dr[idx].sink = devm_kasprintf(dev, GFP_KERNEL, "HiFi Playback");
dr[idx].source = devm_kasprintf(dev, GFP_KERNEL, "ssp%d Tx", ssp_port);
if (!dr[idx].sink || !dr[idx].source)
return -ENOMEM;
*routes = dr;
*num_routes = num_dr;
return 0;
}
static int avs_max98357a_probe(struct platform_device *pdev) static int avs_max98357a_probe(struct platform_device *pdev)
{ {
struct snd_soc_dapm_route *routes;
struct snd_soc_dai_link *dai_link; struct snd_soc_dai_link *dai_link;
struct snd_soc_acpi_mach *mach; struct snd_soc_acpi_mach *mach;
struct snd_soc_card *card; struct snd_soc_card *card;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
const char *pname; const char *pname;
int num_routes, ssp_port, ret; int ssp_port, ret;
mach = dev_get_platdata(dev); mach = dev_get_platdata(dev);
pname = mach->mach_params.platform; pname = mach->mach_params.platform;
@ -132,12 +105,6 @@ static int avs_max98357a_probe(struct platform_device *pdev)
return ret; return ret;
} }
ret = avs_create_dapm_routes(dev, ssp_port, &routes, &num_routes);
if (ret) {
dev_err(dev, "Failed to create dapm routes: %d", ret);
return ret;
}
card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL); card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL);
if (!card) if (!card)
return -ENOMEM; return -ENOMEM;
@ -151,8 +118,8 @@ static int avs_max98357a_probe(struct platform_device *pdev)
card->num_controls = ARRAY_SIZE(card_controls); card->num_controls = ARRAY_SIZE(card_controls);
card->dapm_widgets = card_widgets; card->dapm_widgets = card_widgets;
card->num_dapm_widgets = ARRAY_SIZE(card_widgets); card->num_dapm_widgets = ARRAY_SIZE(card_widgets);
card->dapm_routes = routes; card->dapm_routes = card_base_routes;
card->num_dapm_routes = num_routes; card->num_dapm_routes = ARRAY_SIZE(card_base_routes);
card->fully_routed = true; card->fully_routed = true;
ret = snd_soc_fixup_dai_links_platform_name(card, pname); ret = snd_soc_fixup_dai_links_platform_name(card, pname);