Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-09-20 15:03:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

isdn: hfcpci: check the return value of dma_set_mask() in setup_hw()

Browse Source 
The function dma_set_mask() in setup_hw() can fail, so its return value
should be checked.

Fixes: 1700fe1a10 ("Add mISDN HFC PCI driver")
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jia-Ju Bai 2022-03-05 00:58:16 -08:00 committed by David S. Miller
parent afb3cc1a39
commit d0aeb0d4a3
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/isdn/hardware/mISDN/hfcpci.c
View File

@ -2005,7 +2005,11 @@ setup_hw(struct hfc_pci *hc)
} }
/* Allocate memory for FIFOS */ /* Allocate memory for FIFOS */
/* the memory needs to be on a 32k boundary within the first 4G */ /* the memory needs to be on a 32k boundary within the first 4G */
dma_set_mask(&hc->pdev->dev, 0xFFFF8000); if (dma_set_mask(&hc->pdev->dev, 0xFFFF8000)) {
printk(KERN_WARNING
"HFC-PCI: No usable DMA configuration!\n");
return -EIO;
}
buffer = dma_alloc_coherent(&hc->pdev->dev, 0x8000, &hc->hw.dmahandle, buffer = dma_alloc_coherent(&hc->pdev->dev, 0x8000, &hc->hw.dmahandle,
GFP_KERNEL); GFP_KERNEL);
/* We silently assume the address is okay if nonzero */ /* We silently assume the address is okay if nonzero */