Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-12 07:01:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

orangefs: use S_ISREG(mode) and friends instead of mode & S_IFREG.

Browse Source 
Suggestion from Dan Carpenter.

Signed-off-by: Martin Brandenburg <martin@omnibond.com>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
This commit is contained in:
Martin Brandenburg 2016-02-05 16:37:00 -05:00 committed by Mike Marshall
parent 78699e29fd
commit cf22644a0e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/orangefs/orangefs-utils.c
View File

@ -428,17 +428,17 @@ static int compare_attributes_to_inode(struct inode *inode,
switch (attrs->objtype) {
case ORANGEFS_TYPE_METAFILE:
if (!(inode->i_mode & S_IFREG))
if (!S_ISREG(inode->i_mode))
return 0;
break;
case ORANGEFS_TYPE_DIRECTORY:
if (!(inode->i_mode & S_IFDIR))
if (!S_ISDIR(inode->i_mode))
return 0;
if (inode->i_nlink != 1)
return 0;
break;
case ORANGEFS_TYPE_SYMLINK:
if (!(inode->i_mode & S_IFLNK))
if (!S_ISLNK(inode->i_mode))
return 0;
if (orangefs_inode && symname &&
mask & ORANGEFS_ATTR_SYS_LNK_TARGET)