Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 06:31:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

net: phy: micrel: remove redundant assignment to pointer of_node

Browse Source 
The pointer of_node is being initialized with a value that is never
read and it is being updated later with a new value inside a do-while
loop. The initialization is redundant and can be removed and the
pointer dev is no longer required and can be removed too.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Colin Ian King 2021-06-13 14:27:40 +01:00 committed by David S. Miller
parent 9917060fc3
commit ce4f8afd85
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/net/phy/micrel.c
View File

@ -488,8 +488,7 @@ static int ksz9021_load_values_from_of(struct phy_device *phydev,
static int ksz9021_config_init(struct phy_device *phydev) static int ksz9021_config_init(struct phy_device *phydev)
{ {
const struct device *dev = &phydev->mdio.dev; const struct device_node *of_node;
const struct device_node *of_node = dev->of_node;
const struct device *dev_walker; const struct device *dev_walker;
/* The Micrel driver has a deprecated option to place phy OF /* The Micrel driver has a deprecated option to place phy OF
@ -711,8 +710,7 @@ static int ksz9031_config_rgmii_delay(struct phy_device *phydev)
static int ksz9031_config_init(struct phy_device *phydev) static int ksz9031_config_init(struct phy_device *phydev)
{ {
const struct device *dev = &phydev->mdio.dev; const struct device_node *of_node;
const struct device_node *of_node = dev->of_node;
static const char *clk_skews[2] = {"rxc-skew-ps", "txc-skew-ps"}; static const char *clk_skews[2] = {"rxc-skew-ps", "txc-skew-ps"};
static const char *rx_data_skews[4] = { static const char *rx_data_skews[4] = {
"rxd0-skew-ps", "rxd1-skew-ps", "rxd0-skew-ps", "rxd1-skew-ps",
@ -907,8 +905,7 @@ static int ksz9131_config_rgmii_delay(struct phy_device *phydev)
static int ksz9131_config_init(struct phy_device *phydev) static int ksz9131_config_init(struct phy_device *phydev)
{ {
const struct device *dev = &phydev->mdio.dev; struct device_node *of_node;
struct device_node *of_node = dev->of_node;
char *clk_skews[2] = {"rxc-skew-psec", "txc-skew-psec"}; char *clk_skews[2] = {"rxc-skew-psec", "txc-skew-psec"};
char *rx_data_skews[4] = { char *rx_data_skews[4] = {
"rxd0-skew-psec", "rxd1-skew-psec", "rxd0-skew-psec", "rxd1-skew-psec",