Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-16 09:02:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

serial: lantiq: store and compare return status correctly

Browse Source 
platform_get_irq() returns signed status. It should be stored and
compared as signed value before storing to unsigned variable. Implicit
conversion from signed to unsigned and then comparison with less than
zero is wrong as unsigned value can never be less than zero.

Fixes: f087f01ca2 ("serial: lantiq: Use platform_get_irq() to get the interrupt")
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Link: https://lore.kernel.org/r/YcIf7+oSWWn34ND6@debian-BULLSEYE-live-builder-AMD64
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Muhammad Usama Anjum 2021-12-21 23:41:51 +05:00 committed by Greg Kroah-Hartman
parent b4a29b9480
commit cb559bb974
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/tty/serial/lantiq.c
View File

@ -727,16 +727,20 @@ static int fetch_irq_lantiq(struct device *dev, struct ltq_uart_port *ltq_port)
{
struct uart_port *port = &ltq_port->port;
struct platform_device *pdev = to_platform_device(dev);
int irq;
ltq_port->tx_irq = platform_get_irq(pdev, 0);
if (ltq_port->tx_irq < 0)
return ltq_port->tx_irq;
ltq_port->rx_irq = platform_get_irq(pdev, 1);
if (ltq_port->rx_irq < 0)
return ltq_port->rx_irq;
ltq_port->err_irq = platform_get_irq(pdev, 2);
if (ltq_port->err_irq < 0)
return ltq_port->err_irq;
irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
ltq_port->tx_irq = irq;
irq = platform_get_irq(pdev, 1);
if (irq < 0)
return irq;
ltq_port->rx_irq = irq;
irq = platform_get_irq(pdev, 2);
if (irq < 0)
return irq;
ltq_port->err_irq = irq;
port->irq = ltq_port->tx_irq;