Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-29 14:21:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

checkpatch: improve seq_print->seq_puts suggestion

Browse Source 
Improve the format specifier test by removing any %% before looking for
any remaining % format specifier.

Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Heba Aamer 2015-02-13 14:38:49 -08:00 committed by Linus Torvalds
parent f8e58219dc
commit caac1d5fdd
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
scripts/checkpatch.pl
View File

@ -4854,7 +4854,8 @@ sub process {
# check for seq_printf uses that could be seq_puts # check for seq_printf uses that could be seq_puts
if ($sline =~ /\bseq_printf\s*\(.*"\s*\)\s*;\s*$/) { if ($sline =~ /\bseq_printf\s*\(.*"\s*\)\s*;\s*$/) {
my $fmt = get_quoted_string($line, $rawline); my $fmt = get_quoted_string($line, $rawline);
if ($fmt ne "" && $fmt !~ /[^\\]\%/) { $fmt =~ s/%%//g;
if ($fmt !~ /%/) {
if (WARN("PREFER_SEQ_PUTS", if (WARN("PREFER_SEQ_PUTS",
"Prefer seq_puts to seq_printf\n" . $herecurr) && "Prefer seq_puts to seq_printf\n" . $herecurr) &&
$fix) { $fix) {