Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-27 13:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

scsi: ufs: mcq: qcom: Clean the return path of ufs_qcom_mcq_config_resource()

Browse Source 
Smatch static checker reported:
drivers/ufs/host/ufs-qcom.c:1469
ufs_qcom_mcq_config_resource() info: returning a literal zero is
cleaner

Fix the above warning by returning in place instead of a jump to a label.
Also remove the usage of devm_kfree() as it's unnecessary in this function.

Fixes: c263b4ef73 ("scsi: ufs: core: mcq: Configure resource regions")
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
Link: https://lore.kernel.org/r/3ebd2582af74b81ef7b57149f57c6a3bf0963953.1677721229.git.quic_asutoshd@quicinc.com
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Asutosh Das 2023-03-01 17:42:56 -08:00 committed by Martin K. Petersen
parent c8be073bd2
commit c9507eab9f
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/ufs/host/ufs-qcom.c
View File

@ -1466,7 +1466,7 @@ static int ufs_qcom_mcq_config_resource(struct ufs_hba *hba)
/* Explicitly allocate MCQ resource from ufs_mem */ /* Explicitly allocate MCQ resource from ufs_mem */
res_mcq = devm_kzalloc(hba->dev, sizeof(*res_mcq), GFP_KERNEL); res_mcq = devm_kzalloc(hba->dev, sizeof(*res_mcq), GFP_KERNEL);
if (!res_mcq) if (!res_mcq)
return ret; return -ENOMEM;
res_mcq->start = res_mem->start + res_mcq->start = res_mem->start +
MCQ_SQATTR_OFFSET(hba->mcq_capabilities); MCQ_SQATTR_OFFSET(hba->mcq_capabilities);
@ -1478,7 +1478,7 @@ static int ufs_qcom_mcq_config_resource(struct ufs_hba *hba)
if (ret) { if (ret) {
dev_err(hba->dev, "Failed to insert MCQ resource, err=%d\n", dev_err(hba->dev, "Failed to insert MCQ resource, err=%d\n",
ret); ret);
goto insert_res_err; return ret;
} }
res->base = devm_ioremap_resource(hba->dev, res_mcq); res->base = devm_ioremap_resource(hba->dev, res_mcq);
@ -1495,8 +1495,6 @@ out:
ioremap_err: ioremap_err:
res->base = NULL; res->base = NULL;
remove_resource(res_mcq); remove_resource(res_mcq);
insert_res_err:
devm_kfree(hba->dev, res_mcq);
return ret; return ret;
} }