Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-16 09:02:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

bonding: fix second off-by-one error

Browse Source 
Fix off-by-one error because IFNAMSIZ == 16 and when this
code gets executed we stick a NULL byte where we should not.

How to reproduce:
 with CONFIG_CC_STACKPROTECTOR=y (otherwise it may pass by silently)
 modprobe bonding; echo 1 > /sys/class/net/bond0/bonding/mode;
 echo "AAAAAAAAAAAAAAAA" > /sys/class/net/bond0/bonding/active_slave;

Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>

Note: Sorry for the second patch but I missed this one while checking
      the file. You can squash them into one patch.
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
nikolay@redhat.com 2012-10-31 06:03:52 +00:00 committed by David S. Miller
parent eb6e98a1b2
commit c84e1590d1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/bonding/bond_sysfs.c
View File

@ -1237,7 +1237,7 @@ static ssize_t bonding_store_active_slave(struct device *d,
goto out; goto out;
} }
sscanf(buf, "%16s", ifname); /* IFNAMSIZ */ sscanf(buf, "%15s", ifname); /* IFNAMSIZ */
/* check to see if we are clearing active */ /* check to see if we are clearing active */
if (!strlen(ifname) || buf[0] == '\n') { if (!strlen(ifname) || buf[0] == '\n') {