Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-12 23:23:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

cxl/region: prevent underflow in ways_to_cxl()

Browse Source 
The "ways" variable comes from the user.  The ways_to_cxl() function
has an upper bound but it doesn't check for negatives.  Make
the "ways" variable an unsigned int to fix this bug.

Fixes: 80d10a6cee ("cxl/region: Add interleave geometry attributes")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Yueo3NV2hFCXx1iV@kili
[djbw: fixup interleave_ways_store() to only accept unsigned input]
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Dan Carpenter 2022-08-01 13:20:12 +03:00 committed by Dan Williams
parent 88ab1dde79
commit c7e3548cac
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/cxl/core/region.c
View File

@ -319,10 +319,11 @@ static ssize_t interleave_ways_store(struct device *dev,
struct cxl_decoder *cxld = &cxlrd->cxlsd.cxld;
struct cxl_region *cxlr = to_cxl_region(dev);
struct cxl_region_params *p = &cxlr->params;
int rc, val, save;
unsigned int val, save;
int rc;
u8 iw;
rc = kstrtoint(buf, 0, &val);
rc = kstrtouint(buf, 0, &val);
if (rc)
return rc;

2
drivers/cxl/cxl.h
View File

@ -102,7 +102,7 @@ static inline int granularity_to_cxl(int g, u16 *ig)
return 0;
}
static inline int ways_to_cxl(int ways, u8 *iw)
static inline int ways_to_cxl(unsigned int ways, u8 *iw)
{
if (ways > 16)
return -EINVAL;