Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-09-23 08:23:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

ntb_hw_switchtec: fix logic error

Browse Source 
Newer gcc (version 7 and 8 presumably) warn about a statement mixing
the << operator with logical and:

drivers/ntb/hw/mscc/ntb_hw_switchtec.c: In function 'switchtec_ntb_init_sndev':
drivers/ntb/hw/mscc/ntb_hw_switchtec.c:888:24: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]

My interpretation here is that the author must have intended a bitmask
rather than a comparison, so I'm changing the '&&' to '&', which makes
a lot more sense in the context.

Fixes: 1b249475275d ("ntb_hw_switchtec: Allow using Switchtec NTB in multi-partition setups")
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
This commit is contained in:
Arnd Bergmann 2018-01-16 14:50:51 +01:00 committed by Jon Mason
parent 1e2fd202f8
commit c6fad21a8d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/ntb/hw/mscc/ntb_hw_switchtec.c
View File

@ -898,7 +898,7 @@ static int switchtec_ntb_init_sndev(struct switchtec_ntb *sndev)
} }
sndev->peer_partition = ffs(tpart_vec) - 1; sndev->peer_partition = ffs(tpart_vec) - 1;
if (!(part_map && (1 << sndev->peer_partition))) { if (!(part_map & (1 << sndev->peer_partition))) {
dev_err(&sndev->stdev->dev, dev_err(&sndev->stdev->dev,
"ntb target partition is not NT partition\n"); "ntb target partition is not NT partition\n");
return -ENODEV; return -ENODEV;