Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-26 21:02:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

lib/ts_bm.c: replace zero-length array with flexible-array member

Browse Source 
The current codebase makes use of the zero-length array language extension
to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning in
case the flexible array does not occur last in the structure, which will
help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20200211205620.GA24694@embeddedor
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Gustavo A. R. Silva 2020-04-06 20:10:00 -07:00 committed by Linus Torvalds
parent a44ce51370
commit c6e2ac3b47
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/ts_bm.c
View File

@ -52,7 +52,7 @@ struct ts_bm
u8 * pattern; u8 * pattern;
unsigned int patlen; unsigned int patlen;
unsigned int bad_shift[ASIZE]; unsigned int bad_shift[ASIZE];
unsigned int good_shift[0]; unsigned int good_shift[];
}; };
static unsigned int bm_find(struct ts_config *conf, struct ts_state *state) static unsigned int bm_find(struct ts_config *conf, struct ts_state *state)