Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 06:01:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

HSI: omap-ssi: Remove unnecessary debugfs_create_dir() error check

Browse Source 
Remove the debugfs_create_dir() error check. It's safe to pass in error
pointers to the debugfs API, hence the user isn't supposed to include
error checking of the return values.

Signed-off-by: Yang Ruibin <11162571@vivo.com>
Link: https://lore.kernel.org/r/20240827120816.3910198-1-11162571@vivo.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
This commit is contained in:
Yang Ruibin 2024-08-27 20:08:16 +08:00 committed by Sebastian Reichel
parent 8400291e28
commit c3eddf5e8c
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/hsi/controllers/omap_ssi_core.c
View File

@ -116,22 +116,13 @@ static int ssi_debug_add_ctrl(struct hsi_controller *ssi)
/* SSI controller */ /* SSI controller */
omap_ssi->dir = debugfs_create_dir(dev_name(&ssi->device), NULL); omap_ssi->dir = debugfs_create_dir(dev_name(&ssi->device), NULL);
if (!omap_ssi->dir) debugfs_create_file("regs", S_IRUGO, omap_ssi->dir, ssi, &ssi_regs_fops);
return -ENOMEM;
debugfs_create_file("regs", S_IRUGO, omap_ssi->dir, ssi,
&ssi_regs_fops);
/* SSI GDD (DMA) */ /* SSI GDD (DMA) */
dir = debugfs_create_dir("gdd", omap_ssi->dir); dir = debugfs_create_dir("gdd", omap_ssi->dir);
if (!dir)
goto rback;
debugfs_create_file("regs", S_IRUGO, dir, ssi, &ssi_gdd_regs_fops); debugfs_create_file("regs", S_IRUGO, dir, ssi, &ssi_gdd_regs_fops);
return 0; return 0;
rback:
debugfs_remove_recursive(omap_ssi->dir);
return -ENOMEM;
} }
static void ssi_debug_remove_ctrl(struct hsi_controller *ssi) static void ssi_debug_remove_ctrl(struct hsi_controller *ssi)