Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-09-22 16:03:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

NFSv4: When recovering state fails with EAGAIN, retry the same recovery

Browse Source 
If the server returns with EAGAIN when we're trying to recover from
a server reboot, we currently delay for 1 second, but then mark the
stateid as needing recovery after the grace period has expired.

Instead, we should just retry the same recovery process immediately
after the 1 second delay. Break out of the loop after 10 retries.

Fixes: 35a61606a6 ("NFS: Reduce indentation of the switch statement...")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
This commit is contained in:
Trond Myklebust 2019-07-22 09:54:29 +01:00
parent 86dbd08b32
commit c34fae003c
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
fs/nfs/nfs4state.c
View File

@ -1607,6 +1607,7 @@ static int __nfs4_reclaim_open_state(struct nfs4_state_owner *sp, struct nfs4_st
static int nfs4_reclaim_open_state(struct nfs4_state_owner *sp, const struct nfs4_state_recovery_ops *ops)
{
struct nfs4_state *state;
unsigned int loop = 0;
int status = 0;
/* Note: we rely on the sp->so_states list being ordered
@ -1633,8 +1634,10 @@ restart:
switch (status) {
default:
if (status >= 0)
if (status >= 0) {
loop = 0;
break;
}
printk(KERN_ERR "NFS: %s: unhandled error %d\n", __func__, status);
/* Fall through */
case -ENOENT:
@ -1648,6 +1651,10 @@ restart:
break;
case -EAGAIN:
ssleep(1);
if (loop++ < 10) {
set_bit(ops->state_flag_bit, &state->flags);
break;
}
/* Fall through */
case -NFS4ERR_ADMIN_REVOKED:
case -NFS4ERR_STALE_STATEID: