Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-01-01 15:51:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

ipack: Fail earlier for drivers without probe function

Browse Source 
A driver without a probe function isn't useful as it can never be used.
Let registering such a driver fail already instead of failing every
binding.

This is only cosmetic as there is no ipack driver without a probe function.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Link: https://lore.kernel.org/r/20210207215556.96371-1-uwe@kleine-koenig.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Uwe Kleine-König 2021-02-07 22:55:55 +01:00 committed by Greg Kroah-Hartman
parent e3e3eaab2b
commit c31d32ba58
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/ipack/ipack.c
View File

@ -64,9 +64,6 @@ static int ipack_bus_probe(struct device *device)
struct ipack_device *dev = to_ipack_dev(device); struct ipack_device *dev = to_ipack_dev(device);
struct ipack_driver *drv = to_ipack_driver(device->driver); struct ipack_driver *drv = to_ipack_driver(device->driver);
if (!drv->ops->probe)
return -EINVAL;
return drv->ops->probe(dev); return drv->ops->probe(dev);
} }
@ -252,6 +249,9 @@ EXPORT_SYMBOL_GPL(ipack_bus_unregister);
int ipack_driver_register(struct ipack_driver *edrv, struct module *owner, int ipack_driver_register(struct ipack_driver *edrv, struct module *owner,
const char *name) const char *name)
{ {
if (!edrv->ops->probe)
return -EINVAL;
edrv->driver.owner = owner; edrv->driver.owner = owner;
edrv->driver.name = name; edrv->driver.name = name;
edrv->driver.bus = &ipack_bus_type; edrv->driver.bus = &ipack_bus_type;