Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-16 17:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

eeprom: idt_89hpesx: clean up an error pointer vs NULL inconsistency

Browse Source 
We check for IS_ERR_OR_NULL() here, but later we check the same thing
for NULL only.  It turns out that it can only be NULL so we can make the
checking consistent by removing the ERR_PTR stuff.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2018-08-02 11:27:21 +03:00 committed by Greg Kroah-Hartman
parent 81ae962d7f
commit c01513b4b2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/misc/eeprom/idt_89hpesx.c
View File

@ -1128,7 +1128,7 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev)
device_for_each_child_node(dev, fwnode) {
ee_id = idt_ee_match_id(fwnode);
if (IS_ERR_OR_NULL(ee_id)) {
if (!ee_id) {
dev_warn(dev, "Skip unsupported EEPROM device");
continue;
} else