Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 06:01:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD()

Browse Source 
mac802154 devices update their dev->stats fields locklessly. Therefore
these counters should be updated atomically. Adopt SMP safe DEV_STATS_INC()
and DEV_STATS_ADD() to achieve this.

Signed-off-by: Yunshui Jiang <jiangyunshui@kylinos.cn>
Message-ID: <20240531080739.2608969-1-jiangyunshui@kylinos.cn>
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
This commit is contained in:
Yunshui Jiang 2024-05-31 16:07:39 +08:00 committed by Stefan Schmidt
parent 07aa33988a
commit b8ec0dc384
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
net/mac802154/tx.c
View File

@ -34,8 +34,8 @@ void ieee802154_xmit_sync_worker(struct work_struct *work)
if (res) if (res)
goto err_tx; goto err_tx;
dev->stats.tx_packets++; DEV_STATS_INC(dev, tx_packets);
dev->stats.tx_bytes += skb->len; DEV_STATS_ADD(dev, tx_bytes, skb->len);
ieee802154_xmit_complete(&local->hw, skb, false); ieee802154_xmit_complete(&local->hw, skb, false);
@ -90,8 +90,8 @@ ieee802154_tx(struct ieee802154_local *local, struct sk_buff *skb)
if (ret) if (ret)
goto err_wake_netif_queue; goto err_wake_netif_queue;
dev->stats.tx_packets++; DEV_STATS_INC(dev, tx_packets);
dev->stats.tx_bytes += len; DEV_STATS_ADD(dev, tx_bytes, len);
} else { } else {
local->tx_skb = skb; local->tx_skb = skb;
queue_work(local->workqueue, &local->sync_tx_work); queue_work(local->workqueue, &local->sync_tx_work);