Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-19 02:21:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

PM / wakeup: validate wakeup source before activating it.

Browse Source 
A rogue wakeup source not registered in wakeup_sources list is not visible
from wakeup_sources_stats_show. Check if the wakeup source is registered
properly by looking at the timer struct.

Signed-off-by: Jin Qian <jinqian@android.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Jin Qian 2015-05-06 15:26:56 -07:00 committed by Rafael J. Wysocki
parent 5ebe6afaf0
commit b6ec94520c
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/base/power/wakeup.c
View File

@ -351,6 +351,20 @@ int device_set_wakeup_enable(struct device *dev, bool enable)
} }
EXPORT_SYMBOL_GPL(device_set_wakeup_enable); EXPORT_SYMBOL_GPL(device_set_wakeup_enable);
/**
* wakeup_source_not_registered - validate the given wakeup source.
* @ws: Wakeup source to be validated.
*/
static bool wakeup_source_not_registered(struct wakeup_source *ws)
{
/*
* Use timer struct to check if the given source is initialized
* by wakeup_source_add.
*/
return ws->timer.function != pm_wakeup_timer_fn ||
ws->timer.data != (unsigned long)ws;
}
/* /*
* The functions below use the observation that each wakeup event starts a * The functions below use the observation that each wakeup event starts a
* period in which the system should not be suspended. The moment this period * period in which the system should not be suspended. The moment this period
@ -391,6 +405,10 @@ static void wakeup_source_activate(struct wakeup_source *ws)
{ {
unsigned int cec; unsigned int cec;
if (WARN_ONCE(wakeup_source_not_registered(ws),
"unregistered wakeup source\n"))
return;
/* /*
* active wakeup source should bring the system * active wakeup source should bring the system
* out of PM_SUSPEND_FREEZE state * out of PM_SUSPEND_FREEZE state