Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 14:42:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

usb: musb: omap2430: minor cleanups.

Browse Source 
1/ remove incorrect comment (it is a non-blocking notifier)
2/ Use correct symbolic return value for notifier
3/ Make sure otg_notifier_work is cancelled before module exit.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
NeilBrown 2012-01-25 10:02:46 +02:00 committed by Felipe Balbi
parent c09d6b51d7
commit b30b3c60a2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/musb/omap2430.c
View File

@ -222,7 +222,6 @@ static inline void omap2430_low_level_init(struct musb *musb)
musb_writel(musb->mregs, OTG_FORCESTDBY, l); musb_writel(musb->mregs, OTG_FORCESTDBY, l);
} }
/* blocking notifier support */
static int musb_otg_notifications(struct notifier_block *nb, static int musb_otg_notifications(struct notifier_block *nb,
unsigned long event, void *unused) unsigned long event, void *unused)
{ {
@ -231,7 +230,7 @@ static int musb_otg_notifications(struct notifier_block *nb,
musb->xceiv_event = event; musb->xceiv_event = event;
schedule_work(&musb->otg_notifier_work); schedule_work(&musb->otg_notifier_work);
return 0; return NOTIFY_OK;
} }
static void musb_otg_notifier_work(struct work_struct *data_notifier_work) static void musb_otg_notifier_work(struct work_struct *data_notifier_work)
@ -386,6 +385,7 @@ static void omap2430_musb_disable(struct musb *musb)
static int omap2430_musb_exit(struct musb *musb) static int omap2430_musb_exit(struct musb *musb)
{ {
del_timer_sync(&musb_idle_timer); del_timer_sync(&musb_idle_timer);
cancel_work_sync(&musb->otg_notifier_work);
omap2430_low_level_exit(musb); omap2430_low_level_exit(musb);
otg_put_transceiver(musb->xceiv); otg_put_transceiver(musb->xceiv);