Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 06:31:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

gtp: rename SGSN netlink attribute

Browse Source 
This is a mostly cosmetic rename of the SGSN netlink attribute to
the GTP link.  The justification for this is that we will be making
the module support decapsulation of "downstream" SGSN packets, in
which case the netlink parameter actually refers to the upstream GGSN
peer.  Renaming the parameter makes the relationship clearer.

The legacy name is maintained as a define in the header file in order
to not break existing code.

Signed-off-by: Jonas Bonn <jonas@southpole.se>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Acked-by: Harald Welte <laforge@gnumonks.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jonas Bonn 2017-03-24 23:23:20 +01:00 committed by David S. Miller
parent 8c7314c65a
commit ae6336b57e
2 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/net/gtp.c
View File

@ -56,7 +56,7 @@ struct pdp_ctx {
u16 af; u16 af;
struct in_addr ms_addr_ip4; struct in_addr ms_addr_ip4;
struct in_addr sgsn_addr_ip4; struct in_addr peer_addr_ip4;
struct sock *sk; struct sock *sk;
struct net_device *dev; struct net_device *dev;
@ -489,17 +489,17 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev,
} }
netdev_dbg(dev, "found PDP context %p\n", pctx); netdev_dbg(dev, "found PDP context %p\n", pctx);
rt = ip4_route_output_gtp(&fl4, pctx->sk, pctx->sgsn_addr_ip4.s_addr); rt = ip4_route_output_gtp(&fl4, pctx->sk, pctx->peer_addr_ip4.s_addr);
if (IS_ERR(rt)) { if (IS_ERR(rt)) {
netdev_dbg(dev, "no route to SSGN %pI4\n", netdev_dbg(dev, "no route to SSGN %pI4\n",
&pctx->sgsn_addr_ip4.s_addr); &pctx->peer_addr_ip4.s_addr);
dev->stats.tx_carrier_errors++; dev->stats.tx_carrier_errors++;
goto err; goto err;
} }
if (rt->dst.dev == dev) { if (rt->dst.dev == dev) {
netdev_dbg(dev, "circular route to SSGN %pI4\n", netdev_dbg(dev, "circular route to SSGN %pI4\n",
&pctx->sgsn_addr_ip4.s_addr); &pctx->peer_addr_ip4.s_addr);
dev->stats.collisions++; dev->stats.collisions++;
goto err_rt; goto err_rt;
} }
@ -866,8 +866,8 @@ static void ipv4_pdp_fill(struct pdp_ctx *pctx, struct genl_info *info)
{ {
pctx->gtp_version = nla_get_u32(info->attrs[GTPA_VERSION]); pctx->gtp_version = nla_get_u32(info->attrs[GTPA_VERSION]);
pctx->af = AF_INET; pctx->af = AF_INET;
pctx->sgsn_addr_ip4.s_addr = pctx->peer_addr_ip4.s_addr =
nla_get_be32(info->attrs[GTPA_SGSN_ADDRESS]); nla_get_be32(info->attrs[GTPA_PEER_ADDRESS]);
pctx->ms_addr_ip4.s_addr = pctx->ms_addr_ip4.s_addr =
nla_get_be32(info->attrs[GTPA_MS_ADDRESS]); nla_get_be32(info->attrs[GTPA_MS_ADDRESS]);
@ -957,13 +957,13 @@ static int ipv4_pdp_add(struct gtp_dev *gtp, struct sock *sk,
switch (pctx->gtp_version) { switch (pctx->gtp_version) {
case GTP_V0: case GTP_V0:
netdev_dbg(dev, "GTPv0-U: new PDP ctx id=%llx ssgn=%pI4 ms=%pI4 (pdp=%p)\n", netdev_dbg(dev, "GTPv0-U: new PDP ctx id=%llx ssgn=%pI4 ms=%pI4 (pdp=%p)\n",
pctx->u.v0.tid, &pctx->sgsn_addr_ip4, pctx->u.v0.tid, &pctx->peer_addr_ip4,
&pctx->ms_addr_ip4, pctx); &pctx->ms_addr_ip4, pctx);
break; break;
case GTP_V1: case GTP_V1:
netdev_dbg(dev, "GTPv1-U: new PDP ctx id=%x/%x ssgn=%pI4 ms=%pI4 (pdp=%p)\n", netdev_dbg(dev, "GTPv1-U: new PDP ctx id=%x/%x ssgn=%pI4 ms=%pI4 (pdp=%p)\n",
pctx->u.v1.i_tei, pctx->u.v1.o_tei, pctx->u.v1.i_tei, pctx->u.v1.o_tei,
&pctx->sgsn_addr_ip4, &pctx->ms_addr_ip4, pctx); &pctx->peer_addr_ip4, &pctx->ms_addr_ip4, pctx);
break; break;
} }
@ -994,7 +994,7 @@ static int gtp_genl_new_pdp(struct sk_buff *skb, struct genl_info *info)
if (!info->attrs[GTPA_VERSION] || if (!info->attrs[GTPA_VERSION] ||
!info->attrs[GTPA_LINK] || !info->attrs[GTPA_LINK] ||
!info->attrs[GTPA_SGSN_ADDRESS] || !info->attrs[GTPA_PEER_ADDRESS] ||
!info->attrs[GTPA_MS_ADDRESS]) !info->attrs[GTPA_MS_ADDRESS])
return -EINVAL; return -EINVAL;
@ -1126,7 +1126,7 @@ static int gtp_genl_fill_info(struct sk_buff *skb, u32 snd_portid, u32 snd_seq,
goto nlmsg_failure; goto nlmsg_failure;
if (nla_put_u32(skb, GTPA_VERSION, pctx->gtp_version) || if (nla_put_u32(skb, GTPA_VERSION, pctx->gtp_version) ||
nla_put_be32(skb, GTPA_SGSN_ADDRESS, pctx->sgsn_addr_ip4.s_addr) || nla_put_be32(skb, GTPA_PEER_ADDRESS, pctx->peer_addr_ip4.s_addr) ||
nla_put_be32(skb, GTPA_MS_ADDRESS, pctx->ms_addr_ip4.s_addr)) nla_put_be32(skb, GTPA_MS_ADDRESS, pctx->ms_addr_ip4.s_addr))
goto nla_put_failure; goto nla_put_failure;
@ -1237,7 +1237,7 @@ static struct nla_policy gtp_genl_policy[GTPA_MAX + 1] = {
[GTPA_LINK] = { .type = NLA_U32, }, [GTPA_LINK] = { .type = NLA_U32, },
[GTPA_VERSION] = { .type = NLA_U32, }, [GTPA_VERSION] = { .type = NLA_U32, },
[GTPA_TID] = { .type = NLA_U64, }, [GTPA_TID] = { .type = NLA_U64, },
[GTPA_SGSN_ADDRESS] = { .type = NLA_U32, }, [GTPA_PEER_ADDRESS] = { .type = NLA_U32, },
[GTPA_MS_ADDRESS] = { .type = NLA_U32, }, [GTPA_MS_ADDRESS] = { .type = NLA_U32, },
[GTPA_FLOW] = { .type = NLA_U16, }, [GTPA_FLOW] = { .type = NLA_U16, },
[GTPA_NET_NS_FD] = { .type = NLA_U32, }, [GTPA_NET_NS_FD] = { .type = NLA_U32, },

3
include/uapi/linux/gtp.h
View File

@ -19,7 +19,8 @@ enum gtp_attrs {
GTPA_LINK, GTPA_LINK,
GTPA_VERSION, GTPA_VERSION,
GTPA_TID, /* for GTPv0 only */ GTPA_TID, /* for GTPv0 only */
GTPA_SGSN_ADDRESS, GTPA_PEER_ADDRESS, /* Remote GSN peer, either SGSN or GGSN */
#define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */
GTPA_MS_ADDRESS, GTPA_MS_ADDRESS,
GTPA_FLOW, GTPA_FLOW,
GTPA_NET_NS_FD, GTPA_NET_NS_FD,