Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-14 16:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

net: dsa: hellcreek: Replace bogus comment

Browse Source 
Replace bogus comment about matching the latched timestamp to one of the
received frames. That comment is probably copied from mv88e6xxx and true for
these switches. However, the hellcreek switch is configured to insert the
timestamp directly into the PTP packets.

While here, remove the other comments regarding the list splicing and locking as
well, because it doesn't add any value.

Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20230801131647.84697-1-kurt@linutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Kurt Kanzenbach 2023-08-01 15:16:47 +02:00 committed by Jakub Kicinski
parent ae336f30d5
commit ae3683a342
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/net/dsa/hirschmann/hellcreek_hwtstamp.c
View File

@ -298,17 +298,10 @@ static void hellcreek_get_rxts(struct hellcreek *hellcreek,
struct sk_buff_head received;
unsigned long flags;
/* The latched timestamp belongs to one of the received frames. */
/* Construct Rx timestamps for all received PTP packets. */
__skb_queue_head_init(&received);
/* Lock & disable interrupts */
spin_lock_irqsave(&rxq->lock, flags);
/* Add the reception queue "rxq" to the "received" queue an reintialize
* "rxq". From now on, we deal with "received" not with "rxq"
*/
skb_queue_splice_tail_init(rxq, &received);
spin_unlock_irqrestore(&rxq->lock, flags);
for (; skb; skb = __skb_dequeue(&received)) {