mirror of
https://github.com/torvalds/linux.git
synced 2024-09-25 09:23:11 +00:00
cx82310_eth: use skb_cow_head() to deal with cloned skbs
We need to ensure there is enough headroom to push extra header,
but we also need to check if we are allowed to change headers.
skb_cow_head() is the proper helper to deal with this.
Fixes: cc28a20e77
("introduce cx82310_eth: Conexant CX82310-based ADSL router USB ethernet driver")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: James Hughes <james.hughes@raspberrypi.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
b7c6d26758
commit
a9e840a208
|
@ -293,12 +293,9 @@ static struct sk_buff *cx82310_tx_fixup(struct usbnet *dev, struct sk_buff *skb,
|
||||||
{
|
{
|
||||||
int len = skb->len;
|
int len = skb->len;
|
||||||
|
|
||||||
if (skb_headroom(skb) < 2) {
|
if (skb_cow_head(skb, 2)) {
|
||||||
struct sk_buff *skb2 = skb_copy_expand(skb, 2, 0, flags);
|
|
||||||
dev_kfree_skb_any(skb);
|
dev_kfree_skb_any(skb);
|
||||||
skb = skb2;
|
return NULL;
|
||||||
if (!skb)
|
|
||||||
return NULL;
|
|
||||||
}
|
}
|
||||||
skb_push(skb, 2);
|
skb_push(skb, 2);
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue
Block a user