Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 14:42:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

ipv4: arp_notify address list bug

Browse Source 
This fixes a bug with arp_notify.

If arp_notify is enabled, kernel will crash if address is changed
and no IP address is assigned.
  http://bugzilla.kernel.org/show_bug.cgi?id=14330

Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Stephen Hemminger 2009-10-07 03:18:17 -07:00 committed by David S. Miller
parent 1cec9727fb
commit a21090cff2
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
net/ipv4/devinet.c
View File

@ -1077,12 +1077,16 @@ static int inetdev_event(struct notifier_block *this, unsigned long event,
ip_mc_up(in_dev); ip_mc_up(in_dev);
/* fall through */ /* fall through */
case NETDEV_CHANGEADDR: case NETDEV_CHANGEADDR:
if (IN_DEV_ARP_NOTIFY(in_dev)) /* Send gratuitous ARP to notify of link change */
arp_send(ARPOP_REQUEST, ETH_P_ARP, if (IN_DEV_ARP_NOTIFY(in_dev)) {
in_dev->ifa_list->ifa_address, struct in_ifaddr *ifa = in_dev->ifa_list;
dev,
in_dev->ifa_list->ifa_address, if (ifa)
NULL, dev->dev_addr, NULL); arp_send(ARPOP_REQUEST, ETH_P_ARP,
ifa->ifa_address, dev,
ifa->ifa_address, NULL,
dev->dev_addr, NULL);
}
break; break;
case NETDEV_DOWN: case NETDEV_DOWN:
ip_mc_down(in_dev); ip_mc_down(in_dev);