Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-09-21 15:33:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

kconfig: lxdialog is now sparse clean

Browse Source 
Replacing a gcc idiom with malloc and deleting an unused global
variable made lxdialog sparse clean.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
This commit is contained in:
Sam Ravnborg 2005-11-19 22:17:55 +01:00
parent dec69da856
commit a06104af7d
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
scripts/lxdialog/menubox.c
View File

@ -67,7 +67,7 @@ static void print_item(WINDOW * win, const char *item, int choice,
int selected, int hotkey) int selected, int hotkey)
{ {
int j; int j;
char menu_item[menu_width + 1]; char *menu_item = malloc(menu_width + 1);
strncpy(menu_item, item, menu_width); strncpy(menu_item, item, menu_width);
menu_item[menu_width] = 0; menu_item[menu_width] = 0;
@ -95,6 +95,7 @@ static void print_item(WINDOW * win, const char *item, int choice,
wmove(win, choice, item_x + 1); wmove(win, choice, item_x + 1);
wrefresh(win); wrefresh(win);
} }
free(menu_item);
} }
/* /*
@ -221,7 +222,7 @@ int dialog_menu(const char *title, const char *prompt, int height, int width,
/* /*
* Find length of longest item in order to center menu. * Find length of longest item in order to center menu.
* Set 'choice' to default item. * Set 'choice' to default item.
*/ */
item_x = 0; item_x = 0;
for (i = 0; i < item_no; i++) { for (i = 0; i < item_no; i++) {

2
scripts/lxdialog/util.c
View File

@ -26,8 +26,6 @@ bool use_colors = 1;
const char *backtitle = NULL; const char *backtitle = NULL;
const char *dialog_result;
/* /*
* Attribute values, default is for mono display * Attribute values, default is for mono display
*/ */