Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-13 15:41:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

backlight: locomolcd: fix checkpatch error and warning

Browse Source 
This patch fixes the checkpatch error and warning as below:

  WARNING: space prohibited between function name and open parenthesis '('
  ERROR: trailing statements should be on next line

Also, long comments are fixed for the preferred style and unnecessary
lines are removed.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jingoo Han 2012-12-18 14:21:18 -08:00 committed by Linus Torvalds
parent ae664dba27
commit 9f67675a24
1 changed files with 25 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
drivers/video/backlight/locomolcd.c
View File

@ -107,7 +107,6 @@ void locomolcd_power(int on)
} }
EXPORT_SYMBOL(locomolcd_power); EXPORT_SYMBOL(locomolcd_power);
static int current_intensity; static int current_intensity;
static int locomolcd_set_intensity(struct backlight_device *bd) static int locomolcd_set_intensity(struct backlight_device *bd)
@ -122,13 +121,25 @@ static int locomolcd_set_intensity(struct backlight_device *bd)
intensity = 0; intensity = 0;
switch (intensity) { switch (intensity) {
/* AC and non-AC are handled differently, but produce same results in sharp code? */ /*
case 0: locomo_frontlight_set(locomolcd_dev, 0, 0, 161); break; * AC and non-AC are handled differently,
case 1: locomo_frontlight_set(locomolcd_dev, 117, 0, 161); break; * but produce same results in sharp code?
case 2: locomo_frontlight_set(locomolcd_dev, 163, 0, 148); break; */
case 3: locomo_frontlight_set(locomolcd_dev, 194, 0, 161); break; case 0:
case 4: locomo_frontlight_set(locomolcd_dev, 194, 1, 161); break; locomo_frontlight_set(locomolcd_dev, 0, 0, 161);
break;
case 1:
locomo_frontlight_set(locomolcd_dev, 117, 0, 161);
break;
case 2:
locomo_frontlight_set(locomolcd_dev, 163, 0, 148);
break;
case 3:
locomo_frontlight_set(locomolcd_dev, 194, 0, 161);
break;
case 4:
locomo_frontlight_set(locomolcd_dev, 194, 1, 161);
break;
default: default:
return -ENODEV; return -ENODEV;
} }
@ -175,9 +186,11 @@ static int locomolcd_probe(struct locomo_dev *ldev)
locomo_gpio_set_dir(ldev->dev.parent, LOCOMO_GPIO_FL_VR, 0); locomo_gpio_set_dir(ldev->dev.parent, LOCOMO_GPIO_FL_VR, 0);
/* the poodle_lcd_power function is called for the first time /*
* the poodle_lcd_power function is called for the first time
* from fs_initcall, which is before locomo is activated. * from fs_initcall, which is before locomo is activated.
* We need to recall poodle_lcd_power here*/ * We need to recall poodle_lcd_power here
*/
if (machine_is_poodle()) if (machine_is_poodle())
locomolcd_power(1); locomolcd_power(1);
@ -190,8 +203,8 @@ static int locomolcd_probe(struct locomo_dev *ldev)
&ldev->dev, NULL, &ldev->dev, NULL,
&locomobl_data, &props); &locomobl_data, &props);
if (IS_ERR (locomolcd_bl_device)) if (IS_ERR(locomolcd_bl_device))
return PTR_ERR (locomolcd_bl_device); return PTR_ERR(locomolcd_bl_device);
/* Set up frontlight so that screen is readable */ /* Set up frontlight so that screen is readable */
locomolcd_bl_device->props.brightness = 2; locomolcd_bl_device->props.brightness = 2;
@ -226,7 +239,6 @@ static struct locomo_driver poodle_lcd_driver = {
.resume = locomolcd_resume, .resume = locomolcd_resume,
}; };
static int __init locomolcd_init(void) static int __init locomolcd_init(void)
{ {
return locomo_driver_register(&poodle_lcd_driver); return locomo_driver_register(&poodle_lcd_driver);