Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-17 17:41:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

HID: i2c-hid: fix ret_count check

Browse Source 
ret_count has to be at least 3, as we have to count the 2 bytes that are used
for the size of the reply. Without this, memcpy() might be called with zero or
negative count.

Reported-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Jiri Kosina 2012-12-06 10:59:28 +01:00
parent e5b50fe7be
commit 9afd09a1db
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hid/i2c-hid/i2c-hid.c
View File

@ -520,7 +520,7 @@ static int i2c_hid_get_raw_report(struct hid_device *hid,
ret_count = ihid->inbuf[0] | (ihid->inbuf[1] << 8);
if (!ret_count)
if (ret_count <= 2)
return 0;
ret_count = min(ret_count, ask_count);