Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 22:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

Browse Source 
The VFP, HBP, and HSA are divided between the available lanes if
there is more than one lane.  For certain timings and lane
configurations, the HFP may not be evenly divisible. If the HFP
is rounded down, it ends up being too small which can cause some
monitors to not sync properly. In these instances, adjust htotal
and hsync to round the HFP up, and recalculate the htotal.

This allows 720P-60 to operation on an i.MX8MP with a four-lane
configuration.

Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron BL i.MX8MM with HDMI monitor
Signed-off-by: Adam Ford <aford173@gmail.com>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240601144103.198299-2-aford173@gmail.com
This commit is contained in:
Adam Ford 2024-06-01 09:41:02 -05:00 committed by Robert Foss
parent 78c4c0011b
commit 9a8ac1ec9e
No known key found for this signature in database
GPG Key ID: 3EFD900F76D1D784
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/gpu/drm/bridge/samsung-dsim.c
View File

@ -1606,6 +1606,27 @@ static int samsung_dsim_atomic_check(struct drm_bridge *bridge,
adjusted_mode->flags |= (DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC);
}
/*
* When using video sync pulses, the HFP, HBP, and HSA are divided between
* the available lanes if there is more than one lane. For certain
* timings and lane configurations, the HFP may not be evenly divisible.
* If the HFP is rounded down, it ends up being too small which can cause
* some monitors to not sync properly. In these instances, adjust htotal
* and hsync to round the HFP up, and recalculate the htotal. Through trial
* and error, it appears that the HBP and HSA do not appearto need the same
* correction that HFP does.
*/
if (dsi->lanes > 1) {
int hfp = adjusted_mode->hsync_start - adjusted_mode->hdisplay;
int remainder = hfp % dsi->lanes;
if (remainder) {
adjusted_mode->hsync_start += remainder;
adjusted_mode->hsync_end += remainder;
adjusted_mode->htotal += remainder;
}
}
return 0;
}