Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-23 11:21:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

hwspinlock: sprd: Use struct_size() helper in devm_kzalloc()

Browse Source 
Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.

Also, address the following sparse warnings:
drivers/hwspinlock/sprd_hwspinlock.c:96:36: warning: using sizeof on a flexible structure

Link: https://github.com/KSPP/linux/issues/174
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220125225723.GA78256@embeddedor
This commit is contained in:
Gustavo A. R. Silva 2022-01-25 16:57:23 -06:00 committed by Bjorn Andersson
parent 3e5f1ff7e4
commit 9a41358972
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/hwspinlock/sprd_hwspinlock.c
View File

@ -93,8 +93,7 @@ static int sprd_hwspinlock_probe(struct platform_device *pdev)
return -ENODEV; return -ENODEV;
sprd_hwlock = devm_kzalloc(&pdev->dev, sprd_hwlock = devm_kzalloc(&pdev->dev,
sizeof(struct sprd_hwspinlock_dev) + struct_size(sprd_hwlock, bank.lock, SPRD_HWLOCKS_NUM),
SPRD_HWLOCKS_NUM * sizeof(*lock),
GFP_KERNEL); GFP_KERNEL);
if (!sprd_hwlock) if (!sprd_hwlock)
return -ENOMEM; return -ENOMEM;