Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-26 12:52:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ALSA] ymfpci - Fix race at removal

Browse Source 
free_irq() must be called first to avoid races at removal.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai 2008-03-22 10:11:08 +01:00
parent cd97f47df3
commit 95866d3802
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sound/pci/ymfpci/ymfpci_main.c
View File

@ -2249,6 +2249,8 @@ static int snd_ymfpci_free(struct snd_ymfpci *chip)
#ifdef CONFIG_PM #ifdef CONFIG_PM
vfree(chip->saved_regs); vfree(chip->saved_regs);
#endif #endif
if (chip->irq >= 0)
free_irq(chip->irq, chip);
release_and_free_resource(chip->mpu_res); release_and_free_resource(chip->mpu_res);
release_and_free_resource(chip->fm_res); release_and_free_resource(chip->fm_res);
snd_ymfpci_free_gameport(chip); snd_ymfpci_free_gameport(chip);
@ -2257,8 +2259,6 @@ static int snd_ymfpci_free(struct snd_ymfpci *chip)
if (chip->work_ptr.area) if (chip->work_ptr.area)
snd_dma_free_pages(&chip->work_ptr); snd_dma_free_pages(&chip->work_ptr);
if (chip->irq >= 0)
free_irq(chip->irq, chip);
release_and_free_resource(chip->res_reg_area); release_and_free_resource(chip->res_reg_area);
pci_write_config_word(chip->pci, 0x40, chip->old_legacy_ctrl); pci_write_config_word(chip->pci, 0x40, chip->old_legacy_ctrl);