Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 14:42:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

phy: phy-brcm-usb: specify init function format at struct level

Browse Source 
This is slightly cleaner solution that assures noone assings a wrong
function to the pointer.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20201216143305.12179-2-zajec5@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Rafał Miłecki 2020-12-16 15:33:05 +01:00 committed by Vinod Koul
parent d14f4cce93
commit 915f1d230e
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/phy/broadcom/phy-brcm-usb.c
View File

@ -35,7 +35,7 @@ struct value_to_name_map {
};
struct match_chip_info {
void *init_func;
void (*init_func)(struct brcm_usb_init_params *params);
u8 required_regs[BRCM_REGS_MAX + 1];
u8 optional_reg;
};
@ -428,7 +428,6 @@ static int brcm_usb_phy_probe(struct platform_device *pdev)
struct device_node *dn = pdev->dev.of_node;
int err;
const char *mode;
void (*dvr_init)(struct brcm_usb_init_params *params);
const struct match_chip_info *info;
struct regmap *rmap;
int x;
@ -444,8 +443,8 @@ static int brcm_usb_phy_probe(struct platform_device *pdev)
info = of_device_get_match_data(&pdev->dev);
if (!info)
return -ENOENT;
dvr_init = info->init_func;
(*dvr_init)(&priv->ini);
info->init_func(&priv->ini);
dev_dbg(dev, "Best mapping table is for %s\n",
priv->ini.family_name);