mirror of
https://github.com/torvalds/linux.git
synced 2024-12-24 11:51:27 +00:00
rtc: 88pm80x: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230304133028.2135435-2-u.kleine-koenig@pengutronix.de Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
parent
fe15c26ee2
commit
8ef70a5ef3
@ -317,11 +317,10 @@ out:
|
||||
return ret;
|
||||
}
|
||||
|
||||
static int pm80x_rtc_remove(struct platform_device *pdev)
|
||||
static void pm80x_rtc_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct pm80x_rtc_info *info = platform_get_drvdata(pdev);
|
||||
pm80x_free_irq(info->chip, info->irq, info);
|
||||
return 0;
|
||||
}
|
||||
|
||||
static struct platform_driver pm80x_rtc_driver = {
|
||||
@ -330,7 +329,7 @@ static struct platform_driver pm80x_rtc_driver = {
|
||||
.pm = &pm80x_rtc_pm_ops,
|
||||
},
|
||||
.probe = pm80x_rtc_probe,
|
||||
.remove = pm80x_rtc_remove,
|
||||
.remove_new = pm80x_rtc_remove,
|
||||
};
|
||||
|
||||
module_platform_driver(pm80x_rtc_driver);
|
||||
|
Loading…
Reference in New Issue
Block a user