Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-17 01:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

HID: hidraw: fix improper mutex release

Browse Source 
Mutex can not be released unless all hid_device members are properly
initialized. Otherwise it would result in a race condition that can
cause NULL pointer kernel panic issue in hidraw_open where it uses
uninitialized 'list' member in list_add_tail().

Signed-off-by: Yonghua Zheng <younghua.zheng@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Yonghua Zheng 2013-07-30 14:16:10 +08:00 committed by Jiri Kosina
parent 6f49801827
commit 8e552e5359
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hid/hidraw.c
View File

@ -518,7 +518,6 @@ int hidraw_connect(struct hid_device *hid)
goto out; goto out;
} }
mutex_unlock(&minors_lock);
init_waitqueue_head(&dev->wait); init_waitqueue_head(&dev->wait);
INIT_LIST_HEAD(&dev->list); INIT_LIST_HEAD(&dev->list);
@ -528,6 +527,7 @@ int hidraw_connect(struct hid_device *hid)
dev->exist = 1; dev->exist = 1;
hid->hidraw = dev; hid->hidraw = dev;
mutex_unlock(&minors_lock);
out: out:
return result; return result;