Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-14 08:02:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

mfd: Fix TWL4030 COR bit polarity for BCI SIH block

Browse Source 
The chip TRM documentation contradicts itself about this bit, page 174
of swcu050e says bit should be 0 for clear-on-read behavior, while
page 487 says it should be 1. Testing shows it should be 1, so set
the .set_cor flag accordingly. This is needed for upcoming BCI
charging driver to function.

Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Grazvydas Ignotas 2010-09-28 16:22:19 +03:00 committed by Samuel Ortiz
parent a28dbea0ad
commit 8e52e279b2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/mfd/twl4030-irq.c
View File

@ -144,6 +144,7 @@ static const struct sih sih_modules_twl4030[6] = {
.name = "bci", .name = "bci",
.module = TWL4030_MODULE_INTERRUPTS, .module = TWL4030_MODULE_INTERRUPTS,
.control_offset = TWL4030_INTERRUPTS_BCISIHCTRL, .control_offset = TWL4030_INTERRUPTS_BCISIHCTRL,
.set_cor = true,
.bits = 12, .bits = 12,
.bytes_ixr = 2, .bytes_ixr = 2,
.edr_offset = TWL4030_INTERRUPTS_BCIEDR1, .edr_offset = TWL4030_INTERRUPTS_BCIEDR1,
@ -408,7 +409,7 @@ static int twl4030_init_sih_modules(unsigned line)
* set Clear-On-Read (COR) bit. * set Clear-On-Read (COR) bit.
* *
* NOTE that sometimes COR polarity is documented as being * NOTE that sometimes COR polarity is documented as being
* inverted: for MADC and BCI, COR=1 means "clear on write". * inverted: for MADC, COR=1 means "clear on write".
* And for PWR_INT it's not documented... * And for PWR_INT it's not documented...
*/ */
if (sih->set_cor) { if (sih->set_cor) {