Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-12 23:23:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

mctp: Fix warnings reported by clang-analyzer

Browse Source 
net/mctp/device.c:140:11: warning: Assigned value is garbage or undefined
[clang-analyzer-core.uninitialized.Assign]
        mcb->idx = idx;

- Not a real problem due to how the callback runs, fix the warning.

net/mctp/route.c:458:4: warning: Value stored to 'msk' is never read
[clang-analyzer-deadcode.DeadStores]
        msk = container_of(key->sk, struct mctp_sock, sk);

- 'msk' dead assignment can be removed here.

Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Matt Johnston 2022-02-22 12:29:36 +08:00 committed by David S. Miller
parent 3185485cfa
commit 8d783197f0
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/mctp/device.c
View File

@ -120,7 +120,7 @@ static int mctp_dump_addrinfo(struct sk_buff *skb, struct netlink_callback *cb)
struct ifaddrmsg *hdr; struct ifaddrmsg *hdr;
struct mctp_dev *mdev; struct mctp_dev *mdev;
int ifindex; int ifindex;
int idx, rc; int idx = 0, rc;
hdr = nlmsg_data(cb->nlh); hdr = nlmsg_data(cb->nlh);
// filter by ifindex if requested // filter by ifindex if requested

1
net/mctp/route.c
View File

@ -456,7 +456,6 @@ static int mctp_route_input(struct mctp_route *route, struct sk_buff *skb)
* the reassembly/response key * the reassembly/response key
*/ */
if (!rc && flags & MCTP_HDR_FLAG_EOM) { if (!rc && flags & MCTP_HDR_FLAG_EOM) {
msk = container_of(key->sk, struct mctp_sock, sk);
sock_queue_rcv_skb(key->sk, key->reasm_head); sock_queue_rcv_skb(key->sk, key->reasm_head);
key->reasm_head = NULL; key->reasm_head = NULL;
__mctp_key_done_in(key, net, f, MCTP_TRACE_KEY_REPLIED); __mctp_key_done_in(key, net, f, MCTP_TRACE_KEY_REPLIED);