mirror of
https://github.com/torvalds/linux.git
synced 2024-09-21 07:23:06 +00:00
xfs: reset XFS_ATTR_INCOMPLETE filter on node removal
In XFS_DAS_NODE_REMOVE_ATTR case, xfs_attr_mode_remove_attr() sets
filter to XFS_ATTR_INCOMPLETE. The filter is then reset in
xfs_attr_complete_op() if XFS_DA_OP_REPLACE operation is performed.
The filter is not reset though if XFS just removes the attribute
(args->value == NULL) with xfs_attr_defer_remove(). attr code goes
to XFS_DAS_DONE state.
Fix this by always resetting XFS_ATTR_INCOMPLETE filter. The replace
operation already resets this filter in anyway and others are
completed at this step hence don't need it.
Fixes: fdaf1bb3ca
("xfs: ATTR_REPLACE algorithm with LARP enabled needs rework")
Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
This commit is contained in:
parent
41bccc98fb
commit
82ef1a5356
|
@ -421,10 +421,10 @@ xfs_attr_complete_op(
|
|||
bool do_replace = args->op_flags & XFS_DA_OP_REPLACE;
|
||||
|
||||
args->op_flags &= ~XFS_DA_OP_REPLACE;
|
||||
if (do_replace) {
|
||||
args->attr_filter &= ~XFS_ATTR_INCOMPLETE;
|
||||
args->attr_filter &= ~XFS_ATTR_INCOMPLETE;
|
||||
if (do_replace)
|
||||
return replace_state;
|
||||
}
|
||||
|
||||
return XFS_DAS_DONE;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue
Block a user