Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-27 13:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

[PATCH] RTC subsystem: RS5C372 sysfs fix

Browse Source 
Fix sysfs show() return code

Signed-off-by: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Alessandro Zummo 2006-04-10 22:54:44 -07:00 committed by Linus Torvalds
parent adfb434125
commit 8289607249
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/rtc/rtc-rs5c372.c
View File

@ -169,24 +169,26 @@ static struct rtc_class_ops rs5c372_rtc_ops = {
static ssize_t rs5c372_sysfs_show_trim(struct device *dev, static ssize_t rs5c372_sysfs_show_trim(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
int trim; int err, trim;
if (rs5c372_get_trim(to_i2c_client(dev), NULL, &trim) == 0) err = rs5c372_get_trim(to_i2c_client(dev), NULL, &trim);
return sprintf(buf, "0x%2x\n", trim); if (err)
return err;
return 0; return sprintf(buf, "0x%2x\n", trim);
} }
static DEVICE_ATTR(trim, S_IRUGO, rs5c372_sysfs_show_trim, NULL); static DEVICE_ATTR(trim, S_IRUGO, rs5c372_sysfs_show_trim, NULL);
static ssize_t rs5c372_sysfs_show_osc(struct device *dev, static ssize_t rs5c372_sysfs_show_osc(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
int osc; int err, osc;
if (rs5c372_get_trim(to_i2c_client(dev), &osc, NULL) == 0) err = rs5c372_get_trim(to_i2c_client(dev), &osc, NULL);
return sprintf(buf, "%d.%03d KHz\n", osc / 1000, osc % 1000); if (err)
return err;
return 0; return sprintf(buf, "%d.%03d KHz\n", osc / 1000, osc % 1000);
} }
static DEVICE_ATTR(osc, S_IRUGO, rs5c372_sysfs_show_osc, NULL); static DEVICE_ATTR(osc, S_IRUGO, rs5c372_sysfs_show_osc, NULL);