Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-13 23:51:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

md/raid10: fix null ptr dereference in raid10_size()

Browse Source 
In raid10_run() if raid10_set_queue_limits() succeed, the return value
is set to zero, and if following procedures failed raid10_run() will
return zero while mddev->private is still NULL, causing null ptr
dereference in raid10_size().

Fix the problem by only overwrite the return value if
raid10_set_queue_limits() failed.

Fixes: 3d8466ba68 ("md/raid10: use the atomic queue limit update APIs")
Cc: stable@vger.kernel.org
Reported-and-tested-by: ValdikSS <iam@valdikss.org.ru>
Closes: https://lore.kernel.org/all/0dd96820-fe52-4841-bc58-dbf14d6bfcc8@valdikss.org.ru/
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20241009014914.1682037-1-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org>
This commit is contained in:
Yu Kuai 2024-10-09 09:49:14 +08:00 committed by Song Liu
parent 62ce0782bb
commit 825711e001
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/md/raid10.c
View File

@ -4061,9 +4061,12 @@ static int raid10_run(struct mddev *mddev)
} }
if (!mddev_is_dm(conf->mddev)) { if (!mddev_is_dm(conf->mddev)) {
ret = raid10_set_queue_limits(mddev); int err = raid10_set_queue_limits(mddev);
if (ret)
if (err) {
ret = err;
goto out_free_conf; goto out_free_conf;
}
} }
/* need to check that every block has at least one working mirror */ /* need to check that every block has at least one working mirror */