mirror of
https://github.com/torvalds/linux.git
synced 2024-11-16 00:52:01 +00:00
sysfs: fix parent refcounting during rename and move
Parent reference wasn't properly transferred during rename and move. Fix it. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
42b37df6ab
commit
7f7cfffe60
@ -497,6 +497,9 @@ int sysfs_rename_dir(struct kobject * kobj, struct dentry *new_parent,
|
||||
d_move(kobj->dentry, new_dentry);
|
||||
|
||||
list_del_init(&sd->s_sibling);
|
||||
sysfs_get(parent_sd);
|
||||
sysfs_put(sd->s_parent);
|
||||
sd->s_parent = parent_sd;
|
||||
list_add(&sd->s_sibling, &parent_sd->s_children);
|
||||
|
||||
error = 0;
|
||||
@ -550,6 +553,9 @@ again:
|
||||
|
||||
/* Remove from old parent's list and insert into new parent's list. */
|
||||
list_del_init(&sd->s_sibling);
|
||||
sysfs_get(new_parent_sd);
|
||||
sysfs_put(sd->s_parent);
|
||||
sd->s_parent = new_parent_sd;
|
||||
list_add(&sd->s_sibling, &new_parent_sd->s_children);
|
||||
|
||||
out:
|
||||
|
Loading…
Reference in New Issue
Block a user